CI: Skip numpy dev failing tests #39090
Conversation
phofl
commented
Jan 10, 2021
phofl
commented
- xref CI: Numpy changed dtype inference #39089
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
|
After fixing the underlying cause we can simply revert this. |
pandas/tests/base/test_misc.py
Outdated
| @@ -4,6 +4,7 @@ | |||
| import pytest | |||
|
|
|||
| from pandas.compat import IS64, PYPY | |||
| from pandas.compat.numpy import is_numpy_dev | |||
There was a problem hiding this comment.
this import should be in the prior
There was a problem hiding this comment.
You mean we should be able to import this from pandas.compat?
There was a problem hiding this comment.
Ok will pull the function up then so that we can import from there too
There was a problem hiding this comment.
Like this?
Should this hold true for every other function defined in the numpy folder?
| @@ -107,6 +108,7 @@ def test_drop_names(self): | |||
| expected = Index(["a", "b", "c"], name="first") | |||
| tm.assert_index_equal(dropped.index, expected) | |||
|
|
|||
| @pytest.mark.xfail(is_numpy_dev, reason="GH#39089 Numpy changed dtype inference") | |||
There was a problem hiding this comment.
can u add an issue number to all of these (open one);
we might need to backport this as well
also see if u can find a linked numpy issue - this is a breaking change and might want to have them revert this
|
|
||
|
|
||
| __all__ = [ | ||
| "is_numpy_dev", |
There was a problem hiding this comment.
dont we also need everything else currently in the namespace?
There was a problem hiding this comment.
Yeah probably, but not sure if we should rather do this as a follow up? If numpy fixes the bug or after we have fixed this on our site, we could simply revert this pr to avoid touching 30 files. If we do more in here, this may get tricky
|
right do the namespace changes first as a separate PR |
|
ok let's just merge this until it's fixed |
This reverts commit 3bd3d1e
* CI: Skip numpy dev failing tests * Xfail missed test * Pull is_numpy_dev up
…dev#39225) This reverts commit 3bd3d1e
…dev#39225) This reverts commit 3bd3d1e
