Skip to content

MOVE: describe to pandas/core/describe.py #39102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

ivanovmg
Copy link
Member

@ivanovmg ivanovmg commented Jan 11, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Move describe functionality to a separate module and prepare for the further refactor/simplification (xref #36833).

  • Created new module pandas/core/describe.py
  • Delegate the functionality of NDFrame.describe to function describe_ndframe in the new module

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location suggestion. ping on green.

thanks for just moving.

@@ -0,0 +1,205 @@
"""
Module responsible for execution of NDFrame.describe() method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would put in pandas/core/describe.py

@jreback jreback added this to the 1.3 milestone Jan 11, 2021
@jreback jreback added the Refactor Internal refactoring of code label Jan 11, 2021
@ivanovmg ivanovmg changed the title MOVE: describe to pandas/io/formats/describe.py MOVE: describe to pandas/core/describe.py Jan 11, 2021
@jreback
Copy link
Contributor

jreback commented Jan 11, 2021

@ivanovmg actually can you merge master again, think i just merged an incompatible change here

@jreback
Copy link
Contributor

jreback commented Jan 11, 2021

great ping on green

@ivanovmg
Copy link
Member Author

great ping on green

@jreback, it is green.

@jreback jreback merged commit c4f15e4 into pandas-dev:master Jan 11, 2021
@jreback
Copy link
Contributor

jreback commented Jan 11, 2021

thanks @ivanovmg

@ivanovmg ivanovmg deleted the refactor/describe branch January 12, 2021 06:26
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants