Skip to content

REF: move 'describe' functions to new file #31154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
david-cortes opened this issue Jan 20, 2020 · 2 comments
Closed

REF: move 'describe' functions to new file #31154

david-cortes opened this issue Jan 20, 2020 · 2 comments
Labels
Testing pandas testing functions or related to the test suite

Comments

@david-cortes
Copy link
Contributor

david-cortes commented Jan 20, 2020

Opening an issue about a refactor of the code for the describe method in Series and DataFrames as requested here: #30209
Idea was to move all the helper functions (according to type) into a new file pandas/core/algos/describe.py

And to redo the tests on describe methods by dtype using parametrize.


Seeing as the current organization of the files in the master branch does not follow this arrangement and would imply some perhaps bug changes, I'd prefer not to work on this myself.

@jbrockmendel jbrockmendel added the Refactor Internal refactoring of code label Feb 25, 2020
@mzeitlin11
Copy link
Member

Think the refactor portion was taken care of by a string of PR's like #39102, but don't think the testing parameterization looked at

@mzeitlin11 mzeitlin11 added Testing pandas testing functions or related to the test suite and removed Refactor Internal refactoring of code labels Jun 26, 2021
@mzeitlin11 mzeitlin11 added this to the Contributions Welcome milestone Jun 26, 2021
@jbrockmendel
Copy link
Member

Closing as completed. Test de-duplication goal is implied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

3 participants