CLN: Numpy compat functions namespace #39092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's save this until we revert the numpy fixes |
|
Sounds good, will fix the errors in the meantime. Will reopen when reverted |
|
Reopening since the other commit was reverted. Should we make |
jreback
reviewed
Jan 19, 2021
| @@ -15,8 +15,7 @@ | |||
| from pandas._libs.tslib import Timestamp | |||
| from pandas._libs.tslibs import parsing | |||
| from pandas._libs.tslibs.parsing import parse_datetime_string | |||
| from pandas.compat import is_platform_windows | |||
| from pandas.compat.numpy import np_array_datetime64_compat | |||
| from pandas.compat import is_platform_windows, np_array_datetime64_compat | |||
There was a problem hiding this comment.
OT: we can prob remove this np_array_datetime64_compat it is pretty old stuff
jreback
reviewed
Jan 19, 2021
| @@ -10,7 +10,7 @@ | |||
| from pandas._libs.tslibs.parsing import DateParseError | |||
| from pandas._libs.tslibs.period import INVALID_FREQ_ERR_MSG, IncompatibleFrequency | |||
| from pandas._libs.tslibs.timezones import dateutil_gettz, maybe_get_tz | |||
| from pandas.compat.numpy import np_datetime64_compat | |||
| from pandas.compat import np_datetime64_compat | |||
There was a problem hiding this comment.
this too (but just make a new issue for now)
yes |
|
Done, opened #39283 |
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we do something about the private variables
_np_version_under1p19and_np_version_under1p20too?cc @jreback