Skip to content

CLN: Remove np_datetime64_compat and np_array_datetime64_compat #39283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phofl opened this issue Jan 19, 2021 · 2 comments · Fixed by #44895
Closed

CLN: Remove np_datetime64_compat and np_array_datetime64_compat #39283

phofl opened this issue Jan 19, 2021 · 2 comments · Fixed by #44895
Labels
Clean Compat pandas objects compatability with Numpy or Python functions
Milestone
1.4

Comments

@phofl
Copy link
Member

phofl commented Jan 19, 2021

We probably can remove both checks, see #39092
@phofl phofl added Bug Needs Triage Issue that has not been reviewed by a pandas team member Clean Compat pandas objects compatability with Numpy or Python functions and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 19, 2021
@phofl phofl mentioned this issue Jan 19, 2021
Merged
1 task
@jreback jreback added this to the 1.3 milestone Jan 21, 2021
@phofl
Copy link
Member Author

phofl commented Jan 21, 2021

Hm probably can not remove this.

np.datetime64("2014-02-01 00:00Z")

still raising

DeprecationWarning: parsing timezone aware datetimes is deprecated; this will raise an error in the future
  np.datetime64("2014-02-01 00:00Z")

Unless we want to remove the Z?

cc @jreback

@lithomas1 lithomas1 modified the milestones: 1.3, Contributions Welcome Apr 7, 2021
@jbrockmendel
Copy link
Member

We only use it in tests and AFAICT all of those places we'd be better off just stripping the "Z", yes.

@phofl phofl mentioned this issue Dec 15, 2021
Merged
2 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.4 Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

Remove numpy compat functions phofl/pandas
4 participants
@jreback @jbrockmendel @lithomas1 @phofl