Skip to content

BUG: reindexing empty CategoricalIndex would fail if target had duplicates #39046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.3.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ Categorical
- Bug in ``CategoricalIndex.reindex`` failed when ``Index`` passed with elements all in category (:issue:`28690`)
- Bug where constructing a :class:`Categorical` from an object-dtype array of ``date`` objects did not round-trip correctly with ``astype`` (:issue:`38552`)
- Bug in constructing a :class:`DataFrame` from an ``ndarray`` and a :class:`CategoricalDtype` (:issue:`38857`)
- Bug where :class:`DataFrame` axes with an empty :class:`CategoricalIndex` could not be reindexed if the target contained duplicates (:issue:`38906`)

Datetimelike
^^^^^^^^^^^^
Expand Down
10 changes: 7 additions & 3 deletions pandas/core/indexes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -3745,9 +3745,13 @@ def _reindex_non_unique(self, target):
# need to retake to have the same size as the indexer
indexer[~check] = -1

# reset the new indexer to account for the new size
new_indexer = np.arange(len(self.take(indexer)))
new_indexer[~check] = -1
if len(self):
# reset the new indexer to account for the new size
new_indexer = np.arange(len(self.take(indexer)))
new_indexer[~check] = -1
else:
# GH#38906
new_indexer = np.arange(0)

if isinstance(self, ABCMultiIndex):
new_index = type(self).from_tuples(new_labels, names=self.names)
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/frame/indexing/test_categorical.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,4 +385,4 @@ def test_loc_indexing_preserves_index_category_dtype(self):
tm.assert_index_equal(result, expected)

result = df.loc[["a"]].index.levels[0]
tm.assert_index_equal(result, expected)
tm.assert_index_equal(result, expected)
16 changes: 16 additions & 0 deletions pandas/tests/indexing/test_categorical.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,3 +533,19 @@ def test_loc_with_non_string_categories(self, idx_values, ordered):
result.loc[sl, "A"] = ["qux", "qux2"]
expected = DataFrame({"A": ["qux", "qux2", "baz"]}, index=cat_idx)
tm.assert_frame_equal(result, expected)

def test_reindex_empty(self):
df = DataFrame(columns=CategoricalIndex([]), index=["K"], dtype="f8")

# No duplicates
cat_idx = CategoricalIndex(["A", "B"])
result = df.reindex(columns=cat_idx)
expected = DataFrame(index=["K"], columns=cat_idx, dtype="f8")
tm.assert_frame_equal(result, expected)

# Duplicates
# GH#38906
cat_idx = CategoricalIndex(["A", "A"])
result = df.reindex(columns=cat_idx)
expected = DataFrame(index=["K"], columns=cat_idx, dtype="f8")
tm.assert_frame_equal(result, expected)