Skip to content

BUG: reindexing empty CategoricalIndex would fail if target had duplicates #39046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2021
Merged

BUG: reindexing empty CategoricalIndex would fail if target had duplicates #39046

merged 3 commits into from
Jan 10, 2021

Conversation

batterseapower
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Jan 8, 2021 •
edited
Loading

Hello @batterseapower! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-10 00:36:47 UTC

@batterseapower batterseapower force-pushed the gh38906 branch 3 times, most recently from fdb6a5a to f4eb93c Compare January 9, 2021 00:11
arw2019
arw2019 reviewed Jan 9, 2021
View reviewed changes
@batterseapower
Copy link
Contributor Author

These test failures about ports being in use don't seem to be related to my change.

@jreback jreback added Bug Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves labels Jan 9, 2021
jreback
jreback requested changes Jan 9, 2021
View reviewed changes
@jreback jreback added this to the 1.3 milestone Jan 10, 2021
jreback
jreback requested changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on green (pre-commit will fail on an already fixed benchmark issue)

@jreback jreback merged commit e8efc62 into pandas-dev:master Jan 10, 2021
@jreback
Copy link
Contributor

jreback commented Jan 10, 2021

thanks @batterseapower

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@batterseapower @luckyvs1
BUG: reindexing empty CategoricalIndex would fail if target had dupli…
5f3073e 
…cates (pandas-dev#39046)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arw2019 arw2019 arw2019 left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: reindexing empty CategoricalIndex fails if target contains duplicates
4 participants
@batterseapower @pep8speaks @jreback @arw2019