Skip to content

DOC: improve shared content between comparison pages #38933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

afeld
Copy link
Member

@afeld afeld commented Jan 3, 2021

This pull request does a few things between the SAS and Stata pages, in separate commits:

The motivation here is that I'm working on adding the other sections to the Comparison to Spreadsheets page, and want to ensure they're consistent.


  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added the Docs label Jan 4, 2021
@jreback jreback added this to the 1.3 milestone Jan 4, 2021
@jreback
Copy link
Contributor

jreback commented Jan 4, 2021

nice, ping on green.

@jreback jreback merged commit 3526a71 into pandas-dev:master Jan 4, 2021
@jreback
Copy link
Contributor

jreback commented Jan 4, 2021

thanks @afeld

outer_join[pd.notna(outer_join["value_x"])]

pandas also provides a variety of methods to work with missing data -- some of
which would be challenging to express in Stata. For example, there are methods to
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, missed the reference to Stata here. Fixed in #38935.


outer_join = df1.merge(df2, on=["key"], how="outer")
outer_join
.. include:: includes/merge_setup.rst
Copy link
Member Author

@afeld afeld Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, another mistake: copy-and-paste error from above. Also fixed in #38935.

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants