DOC: create shared includes for comparison docs, take III #38887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afeld
commented
Jan 1, 2021
| doc/source/development/contributing_docstring.rst, | ||
| # work around issue of undefined variable warnings | ||
| # https://github.com/pandas-dev/pandas/pull/38837#issuecomment-752884156 | ||
| doc/source/getting_started/comparison/includes/*.rst |
There was a problem hiding this comment.
Per suggestion in #38837 (comment).
5 tasks
jreback
requested changes
Jan 1, 2021
| @@ -0,0 +1,12 @@ | |||
| The same operation in pandas can be accomplished using | |||
There was a problem hiding this comment.
are any of these shared across compraisons? its not big deal, but you can simply re-use them.
There was a problem hiding this comment.
Sorry, what do you mean by "these"?
There was a problem hiding this comment.
oh it looks like you are doing what i thought (e.g. putting includes in a common location) and then using for comparison_excel/sas/r etc. which is great.
so nvm
|
Tests pass! 🎉 |
This will help ensure consistency between the examples.
afeld
force-pushed
the
comparison-includes-C
branch
from
9710efc to
fed55a0
Compare
jreback
approved these changes
Jan 3, 2021
|
thanks @afeld pls have a look at the built docs and issue a followup PR if needed. OT: pls comment on your open PRs / merge master for them to see what we need to merge (IIRC some were WIP) |
This was referenced Jan 3, 2021
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From original pull request (#38771):
closes #xxxxpassesblack pandaspassesgit diff upstream/master -u -- "*.py" | flake8 --diffwhatsnew entry