-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: IntervalIndex.putmask with datetimelike dtypes #37968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
677bd87
CLN: Index.putmask
jbrockmendel 8bd0d9a
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 561808f
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 9daccd7
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 46ed418
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 2c254af
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 3695efc
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel de8051b
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel c45843f
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 9975839
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel be11215
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 0196ebf
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 1f2f677
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 58a0f31
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel 76c01d9
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel ddf5eef
BUG: IntervalIndex.putmask
jbrockmendel 4a0d918
whatsnew, more tests
jbrockmendel 9dc8666
update GH refs
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._data
is defined as_data: ExtensionArray
Is ExtensionIndex only for ndarray backed ExtensionArray? or maybe will need catch AttributeError also eventually?
see also #35032 (comment) (sort of related).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad for not checking the code thoroughly before commenting and just looking at the diff.
I wasn't aware that you recently added a NDArrayBackedExtensionIndex.
Doesn't this add more complexity? what is the motivation for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its just taking methods that are duplicated in CategoricalIndex+DatetimeIndexOpsMixin and putting them in one place. I guess you could say that "adds complexity" bc there is an additional step in the inheritance chain?