BUG: IntervalIndex.putmask with datetimelike dtypes #37968
Conversation
| try: | ||
| value = self._data._validate_setitem_value(value) | ||
| res_values.putmask(mask, value) |
There was a problem hiding this comment.
self._data is defined as _data: ExtensionArray
Is ExtensionIndex only for ndarray backed ExtensionArray? or maybe will need catch AttributeError also eventually?
see also #35032 (comment) (sort of related).
There was a problem hiding this comment.
Ah my bad for not checking the code thoroughly before commenting and just looking at the diff.
I wasn't aware that you recently added a NDArrayBackedExtensionIndex.
Doesn't this add more complexity? what is the motivation for this?
There was a problem hiding this comment.
Doesn't this add more complexity? what is the motivation for this?
Its just taking methods that are duplicated in CategoricalIndex+DatetimeIndexOpsMixin and putting them in one place. I guess you could say that "adds complexity" bc there is an additional step in the inheritance chain?
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffImplements
NDArrayBackedExtensionArray.putmaskwhich will hopefully be rolled into__array_function__to simplify a bunch of code.