Skip to content

CI: update pyupgrade to 2.7.4 in pre-commit #37906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BAlmeidaS
Copy link
Contributor

Updating pyupgrade to 2.7.4 in pre-commit yaml. pre-commit run pyupgrade --all-files runs good 👍

  • closes CI upgrade pyupgrade to v2.7.4 #37891
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
  • passes pre-commit run pyupgrade --all-files

@jreback jreback added this to the 1.2 milestone Nov 17, 2020
@jreback jreback added the Code Style Code style, linting, code_checks label Nov 17, 2020
@MarcoGorelli MarcoGorelli merged commit 2a74fec into pandas-dev:master Nov 17, 2020
@MarcoGorelli
Copy link
Member

Thanks @BAlmeidaS !

@jreback the automated weekly update job from #37362 didn't work: https://github.com/pandas-dev/pandas/actions/runs/365510411

If you added the ACTION_TRIGGER_TOKEN secret token then I don't know why it failed, the logs don't give much away - in which case, I could remove the job and do it manually (as here) when there's an update (which isn't too bad anyway)

@BAlmeidaS BAlmeidaS deleted the pre-commit-update-pyupgrade branch January 17, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI upgrade pyupgrade to v2.7.4
3 participants