Skip to content

CI upgrade pyupgrade to v2.7.4 #37891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Nov 16, 2020 · 2 comments · Fixed by #37906
Closed

CI upgrade pyupgrade to v2.7.4 #37891

MarcoGorelli opened this issue Nov 16, 2020 · 2 comments · Fixed by #37906
Assignees
@BAlmeidaS
Labels
CI Continuous Integration good first issue
Milestone
1.2

Comments

@MarcoGorelli
Copy link
Member

This should just be a matter of changing the version number to v2.7.4 for pyupgrade in .pre-commit-config.yaml, and checking that all still passes:

pre-commit run pyupgrade --all-files

If it does, please open a PR to upgrade - else, report on any failures
@MarcoGorelli MarcoGorelli added CI Continuous Integration good first issue labels Nov 16, 2020
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Nov 16, 2020
@BAlmeidaS
Copy link
Contributor

May I take this one?? This is gonna be my first contribution to Pandas. I know that I should have answered it with take, but I'm felling that I must justify myself.

@MarcoGorelli
Copy link
Member Author

sure, go ahead!

@BAlmeidaS BAlmeidaS mentioned this issue Nov 17, 2020
Merged
6 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BAlmeidaS BAlmeidaS

Labels
CI Continuous Integration good first issue
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

CI: update pyupgrade to 2.7.4 in pre-commit BAlmeidaS/pandas
4 participants
@jreback @BAlmeidaS @simonjayhawkins @MarcoGorelli