Skip to content

CLN: Unused file 'path_to_file.zip' #37903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

lucasrodes
Copy link
Contributor

@lucasrodes lucasrodes commented Nov 16, 2020

New file path_to_file.zip was added in #37844.

I believe this is file is (accidentally?) generated when running scripts/validate_docstrings.py and probably is not needed in the repository.

@lucasrodes
Copy link
Contributor Author

lucasrodes commented Nov 16, 2020

I am not yet familiar with scripts/validate_docstrings.py, but is it possible that it executes the docstring example section?

Related to this, I found this line, where 'path_to_file.zip' appears:

>>> with zipfile.ZipFile('path_to_file.zip', 'w') as zf:

@jreback jreback added the Clean label Nov 17, 2020
@jreback jreback added this to the 1.2 milestone Nov 17, 2020
@jreback jreback merged commit e71210e into pandas-dev:master Nov 17, 2020
@jreback
Copy link
Contributor

jreback commented Nov 17, 2020

good point, thanks @lucasrodes

@jreback
Copy link
Contributor

jreback commented Nov 17, 2020

I am not yet familiar with scripts/validate_docstrings.py, but is it possible that it executes the docstring example section?

Related to this, I found this line, where 'path_to_file.zip' appears:

>>> with zipfile.ZipFile('path_to_file.zip', 'w') as zf:

we only execute this on the CI so nbd there (guess it was picked up when the PR was commited).

i suppose we should just add *.zip to our .gitignore (and other files that we generate just to be safe).

@lucasrodes would love a PR

lucasrodes pushed a commit to lucasrodes/pandas that referenced this pull request Nov 17, 2020
@lucasrodes lucasrodes mentioned this pull request Nov 17, 2020
5 tasks
jreback pushed a commit that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants