Skip to content

DOC: add examples to docstrings of assert_ functions #37844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2020

Conversation

nguevara
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nguevara

@jorisvandenbossche jorisvandenbossche changed the title Added examples DOC: add examples to docstrings of assert_ functions Nov 14, 2020
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nguevara ! Just making a nitpick comment to make the style more consistent with the rest of the codebase

jreback and others added 3 commits November 15, 2020 12:12
Co-authored-by: Marco Gorelli <[email protected]>
Co-authored-by: Marco Gorelli <[email protected]>
Co-authored-by: Marco Gorelli <[email protected]>
@jreback jreback added this to the 1.2 milestone Nov 15, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Nov 15, 2020
@jorisvandenbossche jorisvandenbossche merged commit 1f89b82 into pandas-dev:master Nov 16, 2020
@jorisvandenbossche
Copy link
Member

Thanks a lot @nguevara !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants