Skip to content

making namespace usage more consistent #37852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2020
Merged

making namespace usage more consistent #37852

merged 2 commits into from
Nov 16, 2020

Conversation

christopherhadley
Copy link
Contributor

@christopherhadley christopherhadley commented Nov 14, 2020 •
edited
Loading

@christopherhadley christopherhadley mentioned this pull request Nov 14, 2020
Closed
jbrockmendel
jbrockmendel reviewed Nov 14, 2020
View reviewed changes
pandas/tests/arithmetic/test_numeric.py Outdated
@@ -1054,7 +1054,7 @@ def test_ufunc_compat(self, holder):
tm.assert_equal(result, expected)

@pytest.mark.parametrize(
"holder", [pd.Int64Index, pd.UInt64Index, pd.Float64Index, Series]
"holder", [Int64Index, pd.UInt64Index, pd.Float64Index, Series]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add these other Index classes at the top while we're here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion - I've added these too.

@jbrockmendel
Copy link
Member

small comment, ping on green

@christopherhadley
Copy link
Contributor Author

I've made the suggested changes.

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 15, 2020
@jreback jreback added this to the 1.2 milestone Nov 15, 2020
@MarcoGorelli MarcoGorelli mentioned this pull request Nov 15, 2020
Merged
5 tasks
@jbrockmendel jbrockmendel merged commit c77fc35 into pandas-dev:master Nov 16, 2020
@jbrockmendel
Copy link
Member

thanks @christopherhadley

@christopherhadley christopherhadley deleted the hadley branch November 16, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherhadley @jbrockmendel @jreback