-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Updated script to check inconsistent pandas namespace #37848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated script to check inconsistent pandas namespace #37848
Conversation
Hello @mohdkashif93! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-18 17:28:47 UTC |
we will likely need to merge master to make sure after some other merges (but wait till this is green) |
can you merge master and see if you can fixup and remaining issues ( pre-commits are failing). ping on green. |
this is pending on #37852 , once that's in I'd expect this to pass |
Hi @mohdkashif93 - can you try fetching and merging upstream/master now please and see if this passes? If not, do you want to fix up the remaining files as well? |
yep this needs a rebase and merge on green. |
Yes @MarcoGorelli , I will rebase and check if there are any pending errors with the script 😄 |
can you merge master |
b03f731
to
8435e30
Compare
@jreback I merged master and fixed up the few remaining files - good to go? |
great thanks @mohdkashif93 |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Updates the script for inconsistent namespace usage. To be merged after all the errors are fixed with the updated script. The script is described here : MarcoGorelli/PyDataGlobal2020-sprint#1 by @MarcoGorelli