Skip to content

Upgrade pygrep, use in-built rst-directive-colons #37440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ repos:
- id: flake8
name: flake8 (cython template)
files: \.pxi\.in$
types:
- file
types: [text]
args: [--append-config=flake8/cython-template.cfg]
- repo: https://github.com/PyCQA/isort
rev: 5.6.3
Expand All @@ -32,9 +31,13 @@ repos:
- id: pyupgrade
args: [--py37-plus]
- repo: https://github.com/pre-commit/pygrep-hooks
rev: v1.6.0
rev: v1.7.0
hooks:
- id: rst-backticks
- id: rst-directive-colons
types: [text]
- id: rst-inline-touching-normal
types: [text]
- repo: local
hooks:
- id: pip_to_conda
Expand All @@ -53,19 +56,6 @@ repos:
types: [rst]
args: [--filename=*.rst]
additional_dependencies: [flake8-rst==0.7.0, flake8==3.7.9]
- id: incorrect-sphinx-directives
name: Check for incorrect Sphinx directives
language: pygrep
entry: |
(?x)
# Check for cases of e.g. .. warning: instead of .. warning::
\.\.\ (
autosummary|contents|currentmodule|deprecated|
function|image|important|include|ipython|literalinclude|
math|module|note|raw|seealso|toctree|versionadded|
versionchanged|warning
):[^:]
files: \.(py|pyx|rst)$
- id: non-standard-imports
name: Check for non-standard imports
language: pygrep
Expand Down
2 changes: 1 addition & 1 deletion doc/source/ecosystem.rst
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ Jupyter notebooks can be converted to a number of open standard output formats
Python) through 'Download As' in the web interface and ``jupyter convert``
in a shell.

pandas DataFrames implement ``_repr_html_``and ``_repr_latex`` methods
pandas DataFrames implement ``_repr_html_`` and ``_repr_latex`` methods
which are utilized by Jupyter Notebook for displaying
(abbreviated) HTML or LaTeX tables. LaTeX output is properly escaped.
(Note: HTML tables may or may not be
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/indexes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -3938,7 +3938,7 @@ def _values(self) -> Union[ExtensionArray, np.ndarray]:

This is an ndarray or ExtensionArray.

``_values`` are consistent between``Series`` and ``Index``.
``_values`` are consistent between ``Series`` and ``Index``.

It may differ from the public '.values' method.

Expand Down