Upgrade pygrep, use in-built rst-directive-colons #37440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
CI
|
great thanks @MarcoGorelli very nice! |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a PR in to pre-commit/pygrep-hooks to make the "incorrect-sphinx-directives" hook a built-in one (as it's not specific to pandas) 🎉 So, let's use it?
They also have another useful hook (
rst-inline-touching-normal), which caught a couple of errors which I've fixed below.The reason why I've kept
rst-backticksto justrstfiles (as opposed totypes: [text]like the other two) is that in docstrings, the numpy guide instructs to use single backticks for variable (though if it was ever desirable to change that, then this hook would make it pretty easy to check for consistency)