Skip to content

CI: temporary skip parquet tz test for pyarrow>=2.0.0 #37303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

jorisvandenbossche
Copy link
Member

See #37286, this PR is not the actual fix, but at least ensures we don't have failing CI in other PRs (I prefer to skip the test instead of pinning pyarrow to <= 1.0, since all other tests are passing on 2.0, which is good to still run)

@jorisvandenbossche jorisvandenbossche added this to the 1.1.4 milestone Oct 21, 2020
@jorisvandenbossche jorisvandenbossche added IO Parquet parquet, feather Testing pandas testing functions or related to the test suite labels Oct 21, 2020
@@ -765,6 +765,10 @@ def test_timestamp_nanoseconds(self, pa):
check_round_trip(df, pa, write_kwargs={"version": "2.0"})

def test_timezone_aware_index(self, pa, timezone_aware_date_list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be outside but temporarily is ok

note we actually do want to pin pyarrow in some older builds but i'll comment on the issues

@jreback
Copy link
Contributor

jreback commented Oct 21, 2020

is this not a genuine error https://travis-ci.org/github/pandas-dev/pandas/jobs/737659028 the s3 test

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Oct 21, 2020

Yes, I split a fix for the genuine failure into its own PR: #37304

@jorisvandenbossche jorisvandenbossche merged commit c23ff03 into pandas-dev:master Oct 21, 2020
@jorisvandenbossche jorisvandenbossche deleted the ci-arrow branch October 21, 2020 10:50
@jorisvandenbossche
Copy link
Member Author

note we actually do want to pin pyarrow in some older builds but i'll comment on the issues

Yes, indeed, we will want to pin some builds to pyarrow 1.0, and keep some at latest (separate issue, though, see also #35259 (comment) for some related discussion)

@jorisvandenbossche
Copy link
Member Author

Opened a dedicated issue for this (pinning pyarrow): #37306

@simonjayhawkins
Copy link
Member

1.1.x is not yet failing with pyarrow related failures. https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=45669&view=results

changing milestone here and will backport if/when ci starts to fail.

@simonjayhawkins simonjayhawkins modified the milestones: 1.1.4, 1.2 Oct 21, 2020
@simonjayhawkins
Copy link
Member

1.1.x is not yet failing with pyarrow related failures. https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=45669&view=results

changing milestone here and will backport if/when ci starts to fail.

test_timezone_aware_index was added in #36004 which is only on master

@jorisvandenbossche
Copy link
Member Author

Ah, yes, that's a good reason it is not failing on 1.1.x ;-)

@jorisvandenbossche
Copy link
Member Author

Does the 1.1.x branch have Travis? Because then #37304 might still need to be backported

@jorisvandenbossche
Copy link
Member Author

Hmm, it seems the Travis build on 1.1.x is failing with a conda solve issue

@simonjayhawkins
Copy link
Member

ah, was just mentioning that over on the other issue. It last build on https://travis-ci.org/github/pandas-dev/pandas/builds/736681105

we have some failures that we may need to resolve if we can get it to build consistently. I started to investigate #36779 but my local setup was obviously incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Parquet parquet, feather Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants