Skip to content

CI: tz dtype mismatch in test_parquet following pyarrow upgrade #37296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Testing pandas testing functions or related to the test suite IO Parquet parquet, feather labels Oct 21, 2020
@jreback jreback added this to the 1.1.4 milestone Oct 21, 2020
@jreback
Copy link
Contributor

jreback commented Oct 21, 2020

prob need to backport this

@jbrockmendel
Copy link
Member Author

this caused a different failure in Travis. cc @jorisvandenbossche thoughts on the right way to solve this?

@jorisvandenbossche
Copy link
Member

I am looking into the actual cause (it's our testing machinery that cannot handle with different but equivalent timezones), let's use #37286 to further discuss this.
As a temporary fix to get green CI, I put up #37303 (I prefer that intead of this PR, because setting check_categorical to False is only fixing it "by accident", I think)

@jorisvandenbossche
Copy link
Member

this caused a different failure in Travis

Did a separate PR for that one (not a timezone related failure): #37304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Parquet parquet, feather Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants