Skip to content

DOC: improve description of the example which dataframe has two rows #36971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2020
Merged

DOC: improve description of the example which dataframe has two rows #36971

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55ebe82
fix issue 36970
yonashub Oct 8, 2020
20c3f56
improve description of example
yonashub Oct 9, 2020
f6b1e03
improve description of the example describing mode operation.
yonashub Oct 9, 2020
43396d3
remove trailing extra line
Oct 9, 2020
096e365
preserve newline
MarcoGorelli Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8972,7 +8972,7 @@ def mode(self, axis=0, numeric_only=False, dropna=True) -> DataFrame:

By default, missing values are not considered, and the mode of wings
are both 0 and 2. The second row of species and legs contains ``NaN``,
because they have only one mode, but the DataFrame has two rows.
because they have only one mode, but the resulting DataFrame has two rows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Because the resulting DataFrame has two rows, the second row of ``species`` and ``legs`` contains ``NaN``

? (you may need to wrap this around multiple lines)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is more descriptive. Totally agreed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - could you also put a more descriptive title for your pull request please?


>>> df.mode()
species legs wings
Expand Down