DOC: improve description of the example which dataframe has two rows #36971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve description of the examplewhich dataframe has two rows
MarcoGorelli
reviewed
Oct 8, 2020
pandas/core/frame.py
Outdated
| @@ -8972,7 +8972,7 @@ def mode(self, axis=0, numeric_only=False, dropna=True) -> DataFrame: | |||
|
|
|||
| By default, missing values are not considered, and the mode of wings | |||
| are both 0 and 2. The second row of species and legs contains ``NaN``, | |||
| because they have only one mode, but the DataFrame has two rows. | |||
| because they have only one mode, but the resulting DataFrame has two rows. | |||
There was a problem hiding this comment.
How about
Because the resulting DataFrame has two rows, the second row of ``species`` and ``legs`` contains ``NaN``
? (you may need to wrap this around multiple lines)
There was a problem hiding this comment.
That is more descriptive. Totally agreed
There was a problem hiding this comment.
Cool - could you also put a more descriptive title for your pull request please?
jreback
changed the title
improve description of the example which dataframe has two rows
yonashub
changed the title
MarcoGorelli
reviewed
Oct 9, 2020
MarcoGorelli
approved these changes
Oct 11, 2020
|
Thanks @yonashub In the future, it would be better to create a new branch when submitting PRs, see the contributing guide |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
…andas-dev#36971) * fix issue 36970 improve description of the examplewhich dataframe has two rows * improve description of example improve description of the example which dataframe has two rows * improve description of the example describing mode operation. * remove trailing extra line * preserve newline Co-authored-by: yonas kassa <[email protected]> Co-authored-by: Marco Gorelli <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…andas-dev#36971) * fix issue 36970 improve description of the examplewhich dataframe has two rows * improve description of example improve description of the example which dataframe has two rows * improve description of the example describing mode operation. * remove trailing extra line * preserve newline Co-authored-by: yonas kassa <[email protected]> Co-authored-by: Marco Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve description of the example which dataframe has two rows
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff