Skip to content

BUG: GH36928 Allow dict_keys to be used as column names by read_csv #36937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 10, 2020
Merged

BUG: GH36928 Allow dict_keys to be used as column names by read_csv #36937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5289000
BUG: GH36928 Allow dict_keys to be used as column names by read_csv
abmyii Oct 7, 2020
45e10ff
BUG: GH36928 Add whatsnew entry and move fix to _validate_names funct…
abmyii Oct 7, 2020
b2004b8
BUG: GH36928 Use two backticks instead of one in RST for correct code…
abmyii Oct 7, 2020
1871a41
BUG: GH36928 Improve whatsnew description
abmyii Oct 7, 2020
89c9d51
Update doc/source/whatsnew/v1.1.4.rst
abmyii Oct 7, 2020
053af66
Merge branch 'master' into dict_keys_as_csv_names
abmyii Oct 8, 2020
d165049
Update test_common.py
abmyii Oct 8, 2020
1c2296c
Update test_common.py
abmyii Oct 8, 2020
b3f18b7
Update test_common.py
abmyii Oct 8, 2020
e742741
Update test_common.py
abmyii Oct 8, 2020
c462968
Merge branch 'master' into dict_keys_as_csv_names
abmyii Oct 8, 2020
423545c
Combine conditions
abmyii Oct 8, 2020
5d60dbf
Merge branch 'master' into dict_keys_as_csv_names
jreback Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas/_libs/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,6 +1019,8 @@ cdef inline bint c_is_list_like(object obj, bint allow_sets) except -1:
and not (util.is_array(obj) and obj.ndim == 0)
# exclude sets if allow_sets is False
and not (allow_sets is False and isinstance(obj, abc.Set))
# allow dict_keys objects
or isinstance(obj, abc.KeysView)
)


Expand Down
9 changes: 9 additions & 0 deletions pandas/tests/io/parser/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2221,3 +2221,12 @@ def test_read_table_delim_whitespace_non_default_sep(all_parsers):
)
with pytest.raises(ValueError, match=msg):
parser.read_table(f, delim_whitespace=True, sep=",")


def test_dict_keys_as_names(all_parsers):
data = "a,b\n1,2"

keys = {"a": int, "b": int}.keys()
parser = all_parsers

parser.read_csv(StringIO(data), names=keys)