Skip to content

BUG: GH36928 Allow dict_keys to be used as column names by read_csv #36937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 10, 2020
Merged

BUG: GH36928 Allow dict_keys to be used as column names by read_csv #36937

merged 13 commits into from
Oct 10, 2020

Conversation

abmyii
Copy link
Contributor

@abmyii abmyii commented Oct 7, 2020

@abmyii abmyii force-pushed the dict_keys_as_csv_names branch from a629a9d to 5289000 Compare October 7, 2020 08:16
dsaxton
dsaxton suggested changes Oct 7, 2020
View reviewed changes
@dsaxton dsaxton added this to the 1.1.4 milestone Oct 7, 2020
@dsaxton dsaxton added IO CSV read_csv, to_csv Regression Functionality that used to work in a prior pandas version labels Oct 7, 2020
@dsaxton
Copy link
Member

dsaxton commented Oct 7, 2020

Also can you add a v1.1.4 release note?

@abmyii
Copy link
Contributor Author

abmyii commented Oct 7, 2020

Also can you add a v1.1.4 release note?

Where do I do that?

@dsaxton
Copy link
Member

dsaxton commented Oct 7, 2020

Also can you add a v1.1.4 release note?

Where do I do that?

/doc/source/whatsnew/v1.1.4 in the regressions section

@abmyii
Copy link
Contributor Author

abmyii commented Oct 7, 2020

Done. Thank you for your guidance throughout!

dsaxton
dsaxton approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small wording nit

@pep8speaks
Copy link

pep8speaks commented Oct 8, 2020 •
edited
Loading

Hello @abmyii! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-08 21:11:41 UTC

@abmyii abmyii force-pushed the dict_keys_as_csv_names branch from ae527c7 to 89c9d51 Compare October 8, 2020 07:11
@dsaxton
Copy link
Member

dsaxton commented Oct 8, 2020

@abmyii can you merge master again? I think CI failures are possibly due to upstream changes in isort that appear to be fixed now.

@abmyii
Copy link
Contributor Author

abmyii commented Oct 8, 2020 •
edited
Loading

@abmyii can you merge master again? I think CI failures are possibly due to upstream changes in isort that appear to be fixed now.

How would I do that? git merge master on the dict_keys_as_csv_names branch locally and then push? I don't want to mess anything more up!

@dsaxton
Copy link
Member

dsaxton commented Oct 8, 2020

How would I do that? git merge master on the dict_keys_as_csv_names branch locally and then push? I don't want to mess anything more up!

Locally you can do

git checkout dict_keys_as_csv_names
git fetch upstream
git merge upstream/master

It should merge cleanly.

@abmyii
Copy link
Contributor Author

abmyii commented Oct 8, 2020

Done, thanks.

jreback
jreback requested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment. ping on green.

@abmyii abmyii requested a review from jreback October 9, 2020 06:37
@jreback jreback merged commit 982dae8 into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

thanks @abmyii

@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 12, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 982dae89225531afabbcbe0c52203cfb2408d507
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #36937: BUG: GH36928 Allow dict_keys to be used as column names by read_csv'
  1. Push to a named branch :
git push YOURFORK 1.1.x:auto-backport-of-pr-36937-on-1.1.x
  1. Create a PR against branch 1.1.x, I would have named this PR:

"Backport PR #36937 on branch 1.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Oct 12, 2020
@abmyii @simonjayhawkins
Backport PR pandas-dev#36937 on branch 1.1.x: BUG: GH36928 Allow dict…
fe35eab 
…_keys to be used as column names by read_csv
@simonjayhawkins simonjayhawkins mentioned this pull request Oct 12, 2020
Merged
simonjayhawkins added a commit that referenced this pull request Oct 12, 2020
@simonjayhawkins @abmyii
Backport PR #36937 on branch 1.1.x: BUG: GH36928 Allow dict_keys to b…
42c2c74 
…e used as column names by read_csv (#37078)

Co-authored-by: abmyii <[email protected]>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@abmyii
BUG: GH36928 Allow dict_keys to be used as column names by read_csv (p…
bc19114 
…andas-dev#36937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.

BUG: dict_keys cannot be used as pd.read_csv's names parameter
5 participants
@abmyii @dsaxton @pep8speaks @jreback @simonjayhawkins