Skip to content

DOC: use black to fix code style in doc pandas-dev#36777 #36813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

PrayagS
Copy link
Contributor

@PrayagS PrayagS commented Oct 2, 2020

Partially addresses #36777. Ran black on all the files under doc/source/getting_started/comparison.

Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @PrayagS

@dsaxton
Copy link
Member

dsaxton commented Oct 2, 2020

Actually may have approved too quickly, looks like there are some linting errors

@dsaxton dsaxton added the Docs label Oct 2, 2020
@PrayagS
Copy link
Contributor Author

PrayagS commented Oct 2, 2020

Seems like the latest commit fixed all the linting errors. Please have a look again.

@dsaxton dsaxton merged commit d9feaed into pandas-dev:master Oct 2, 2020
@PrayagS
Copy link
Contributor Author

PrayagS commented Oct 3, 2020

Sorry to bother again, but does this PR now count towards Hacktoberfest? It shows that it is under review but we know that it has been already reviewed and accepted. Do you need to add the hacktoberfest-accepted label?

Source:
image

@dsaxton
Copy link
Member

dsaxton commented Oct 3, 2020

@PrayagS I'm not too familiar with how Hacktoberfest works, but I think you should be good since the PR was merged. As far as I can tell the Hacktoberfest label is optional (we don't have one).

@PrayagS
Copy link
Contributor Author

PrayagS commented Oct 3, 2020

So sorry to disturb again but Hacktoberfest has undergone some changes due to the excessive spamming that occurred this year. The rules for a PR to be accepted have been modified. You can read about it here: https://hacktoberfest.digitalocean.com/hacktoberfest-update

Here is the most important part for maintainers:

image

I can completely understand if pandas as an org doesn't do this but just notifying in case.

@dsaxton
Copy link
Member

dsaxton commented Oct 3, 2020

@PrayagS Ah, looks like we probably do need to add the hacktoberfest topic. Can you create an issue about that?

@PrayagS
Copy link
Contributor Author

PrayagS commented Oct 3, 2020

@dsaxton Done. #36837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants