-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Add hacktoberfest topic to the repo #36837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the suggestion @PrayagS There's already lots of open pull requests, so I'd be hesitant to add the 'hacktoberfest' topic, but let's see what others say |
Hey, how about adding hacktoberfest label only to the issues contributors (interested in contributing to the issue) ask for it? And of course only if you feel the issues are worthy of being part of hacktoberfest! |
@meghana-12 Sadly that wouldn't work as having |
Oh, I see... my bad! |
I don't see why having a lot of open PRs is a reason not to do this. We only need to tag as such when requested by the author, right? No need to do a systematic review of all PRs to tag. |
OK, sure - to be fair, if Hacktoberfest have changed their rules so that PRs need to be accepted to count, then the chances of being overloaded with PRs in the style of - pandas
+ pandas - awesome library should be reduced 😄 |
Yeah, and the maintainers can always mark a PR invalid if necessary. |
It's true that there are a lot of open PRs, but there are even more open issues (many marked as "good first issue"). I also wouldn't want to discourage people who started contributing due to Hacktoberfest before DigitalOcean changed the rules. It isn't too hard to close obvious spam PRs, and I suppose could always remove the topic if things get really out of control. |
I just saw this on the hacktoberfest website : |
I think that sounds like a reasonable compromise. If contributors reference this issue from merged PRs that they want counted, that could also help keeping track. |
@dsaxton +1 |
How to add hacktoberfest topic ? |
Hacktoberfest 2020 has undergone some changes due to the excessive spamming that occurred this year. The rules for a PR to be accepted have been modified. Detailed post on their official website can be found here.
Here is the most important part for maintainers:
As one can see, the maintainers need to add the
hacktoberfest
topic to the repo in order for all the PRs to be considered valid. This is completely opt-in and this issue serves as a notification for the maintainers in case they want to take part.The text was updated successfully, but these errors were encountered: