Skip to content

Test that nan value counts are included when dropna=False. GH#31944 #36783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Test that nan value counts are included when dropna=False. GH#31944 #36783

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8109ac6
Test that nan value counts are included when dropna=False. GH#31944
icanhazcodeplz Oct 1, 2020
271c49a
Style changes
icanhazcodeplz Oct 2, 2020
1bdce41
Test when dropna is True as well
icanhazcodeplz Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pandas/tests/base/test_value_counts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,3 +274,12 @@ def test_value_counts_datetime64(index_or_series):
td2 = klass(td2, name="dt")
result2 = td2.value_counts()
tm.assert_series_equal(result2, expected_s)


def test_value_counts_nan(index_or_series):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call it test_value_counts_with_nan

"""Test that nan value counts are included when dropna=False. GH#31944"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# GH31944 is enough here

klass = index_or_series
s_values = [True, pd.NA, np.nan]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call this data or values

s = klass(s_values)
expected = Series([2, 1], index=[pd.NA, True])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick: can you move this to after res
That way this reads: construct result, construct expected result, compare result with expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense!

tm.assert_series_equal(s.value_counts(dropna=False), expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wanna define res = s.value_counts(dropna=False) and then tm.assert_series_equal(res, expected)