Test that nan value counts are included when dropna=False. GH#31944 #36783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
suggested changes
Oct 1, 2020
| @@ -274,3 +274,12 @@ def test_value_counts_datetime64(index_or_series): | |||
| td2 = klass(td2, name="dt") | |||
| result2 = td2.value_counts() | |||
| tm.assert_series_equal(result2, expected_s) | |||
|
|
|||
|
|
|||
| def test_value_counts_nan(index_or_series): | |||
There was a problem hiding this comment.
I'd call it test_value_counts_with_nan
| def test_value_counts_nan(index_or_series): | ||
| """Test that nan value counts are included when dropna=False. GH#31944""" | ||
| klass = index_or_series | ||
| s_values = [True, pd.NA, np.nan] |
| s_values = [True, pd.NA, np.nan] | ||
| s = klass(s_values) | ||
| expected = Series([2, 1], index=[pd.NA, True]) | ||
| tm.assert_series_equal(s.value_counts(dropna=False), expected) |
There was a problem hiding this comment.
you wanna define res = s.value_counts(dropna=False) and then tm.assert_series_equal(res, expected)
|
|
||
|
|
||
| def test_value_counts_nan(index_or_series): | ||
| """Test that nan value counts are included when dropna=False. GH#31944""" |
arw2019
suggested changes
Oct 2, 2020
| klass = index_or_series | ||
| values = [True, pd.NA, np.nan] | ||
| s = klass(values) | ||
| expected = Series([2, 1], index=[pd.NA, True]) |
There was a problem hiding this comment.
nit-pick: can you move this to after res
That way this reads: construct result, construct expected result, compare result with expected
There was a problem hiding this comment.
Sure, makes sense!
jreback
added
Missing-data
|
Hi y'all, any other changes for this pull request? |
|
thanks @icanhazcodeplz |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdded test per @Dr-Irv request.