[BUG]: Fix bug with pre epoch normalization #36557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � doc/source/whatsnew/v1.1.3.rst
phofl
added
Regression
dsaxton
reviewed
Sep 22, 2020
dsaxton
approved these changes
Sep 22, 2020
� Conflicts: � doc/source/whatsnew/v1.1.3.rst
simonjayhawkins
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Thanks @phofl generally lgtm
Hope the test is in the right place
That seems a reasonable location for the issue code sample.
but the MWE would be Timestamp("1969-01-01 09:00:00").normalize()
maybe add that somewhere in pandas\tests\scalar\timestamp\test_timestamp.py
|
@simonjayhawkins Added the test |
simonjayhawkins
approved these changes
Sep 23, 2020
|
thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 26, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Sep 26, 2020
Co-authored-by: patrick <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThe fix propsed by @jbrockmendel worked.
Hope the test is in the right place