-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: get_indexer returned dtype #36431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2b07e2e
BUG: IndexEngine get_indexer methods return intp arrays
alexhlim e4066e2
TST: changing missing dtype to intp
alexhlim 4a4721a
adding feature to whatsnew
alexhlim d875e36
CLN: reverting astype (#36431)
alexhlim 4d1d076
BUG: HashTable.lookup to use intp arrays (#36431)
alexhlim ad2cdfc
BUG: HashTable.get_labels_groupby to use intp arrays (#36431)
alexhlim aef31e2
BUG: HashTable.get_indexer to use intp arrays (#36431)
alexhlim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -266,7 +266,7 @@ cdef class IndexEngine: | |
""" | ||
cdef: | ||
ndarray values, x | ||
ndarray[int64_t] result, missing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are all of these indexer changed int his file? |
||
ndarray[intp_t] result, missing | ||
set stargets, remaining_stargets | ||
dict d = {} | ||
object val | ||
|
@@ -283,8 +283,8 @@ cdef class IndexEngine: | |
else: | ||
n_alloc = n | ||
|
||
result = np.empty(n_alloc, dtype=np.int64) | ||
missing = np.empty(n_t, dtype=np.int64) | ||
result = np.empty(n_alloc, dtype=np.intp) | ||
missing = np.empty(n_t, dtype=np.intp) | ||
|
||
# map each starget to its position in the index | ||
if stargets and len(stargets) < 5 and self.is_monotonic_increasing: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these all the int64's in this file? (that are indexers)