BUG: get_indexer returned dtype #36431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 17, 2020
jreback
added
the
Compat
jreback
added
Dtype Conversions
jreback
requested changes
Sep 19, 2020
| @@ -347,7 +347,7 @@ cdef class {{name}}HashTable(HashTable): | |||
| int ret = 0 | |||
| {{dtype}}_t val | |||
| khiter_t k | |||
| int64_t[:] locs = np.empty(n, dtype=np.int64) | |||
There was a problem hiding this comment.
are these all the int64's in this file? (that are indexers)
| @@ -266,7 +266,7 @@ cdef class IndexEngine: | |||
| """ | |||
| cdef: | |||
| ndarray values, x | |||
| ndarray[int64_t] result, missing | |||
There was a problem hiding this comment.
are all of these indexer changed int his file?
|
LGTM |
jreback
approved these changes
Sep 19, 2020
|
thanks @alexhlim |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffChanged the return dtype of IndexEngine’s
get_indexer()andget_indexer_non_unique(). I decided to not include tests because dtypes are already implicitly tested in the following:Also, I ran the asv benchmarks: