Skip to content

[TST]: Groupy raised ValueError for ffill with duplicate column names #36326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 13, 2020
Merged

[TST]: Groupy raised ValueError for ffill with duplicate column names #36326

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
732e512
Add test for ffill and duplicate column names
phofl Sep 13, 2020
3d8e02f
Fix Pep8 issues
phofl Sep 13, 2020
78096ac
Create separate file for fill tests
phofl Sep 13, 2020
d89e92e
Resort Imports
phofl Sep 13, 2020
17839b4
Merge branch 'master' of https://github.com/pandas-dev/pandas into 25610
phofl Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2146,3 +2146,16 @@ def test_groupby_column_index_name_lost_fill_funcs(func):
result = getattr(df_grouped, func)().columns
expected = pd.Index(["a", "b"], name="idx")
tm.assert_index_equal(result, expected)


@pytest.mark.parametrize("func", ["ffill", "bfill"])
def test_groupby_fill_duplicate_column_names(func):
# GH: 25610 ValueError with duplicate column names
df1 = pd.DataFrame({"field1": [1, 3, 4], "field2": [1, 3, 4]})
df2 = pd.DataFrame({"field1": [1, np.nan, 4]})
df_grouped = pd.concat([df1, df2], axis=1).groupby(by=["field2"])
expected = pd.DataFrame(
[[1, 1.0], [3, np.nan], [4, 4.0]], columns=["field1", "field1"]
)
result = getattr(df_grouped, func)()
tm.assert_frame_equal(result, expected)