Skip to content

[TST]: Groupy raised ValueError for ffill with duplicate column names #36326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2020
Merged

[TST]: Groupy raised ValueError for ffill with duplicate column names #36326

merged 5 commits into from
Sep 13, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 13, 2020

Was fixed in the past. Added test to avoid regression

@pep8speaks
Copy link

pep8speaks commented Sep 13, 2020 •
edited
Loading

Hello @phofl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-13 20:59:25 UTC

@phofl phofl changed the title [TST: Groupy raised ValueError for ffill with duplicate column names [TST]: Groupy raised ValueError for ffill with duplicate column names Sep 13, 2020
@jreback jreback added Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite labels Sep 13, 2020
@jreback jreback added this to the 1.2 milestone Sep 13, 2020
jreback
jreback requested changes Sep 13, 2020
View reviewed changes
@jreback
Copy link
Contributor

jreback commented Sep 13, 2020

great let's merge on green.

@phofl
Copy link
Member Author

phofl commented Sep 13, 2020

The timeout was probably unrelated?

@rhshadrach
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@jreback jreback merged commit fc61aa9 into pandas-dev:master Sep 13, 2020
@jreback
Copy link
Contributor

jreback commented Sep 13, 2020

thanks @phofl

@phofl phofl deleted the 25610 branch September 13, 2020 22:23
@smithto1 smithto1 mentioned this pull request Oct 8, 2020
Merged
5 tasks
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@phofl
[TST]: Groupy raised ValueError for ffill with duplicate column names (…
62e6d47 
…pandas-dev#36326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

DataFrameGroupBy.ffill with Duplicate Column Labels ValueError
4 participants
@phofl @pep8speaks @jreback @rhshadrach