Skip to content

CI: xfail failing parquet test #36272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2020
Merged

CI: xfail failing parquet test #36272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a603be
CI: xfail failing parquet test
jbrockmendel Sep 10, 2020
83c7c78
xfail on only py38+
jbrockmendel Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions pandas/tests/io/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import numpy as np
import pytest

from pandas.compat import PY38
import pandas.util._test_decorators as td

import pandas as pd
Expand Down Expand Up @@ -564,8 +565,19 @@ def test_s3_roundtrip(self, df_compat, s3_resource, pa, s3so):
write_kwargs=s3so,
)

@td.skip_if_no("s3fs")
@pytest.mark.parametrize("partition_col", [["A"], []])
@td.skip_if_no("s3fs") # also requires flask
@pytest.mark.parametrize(
"partition_col",
[
pytest.param(
["A"],
marks=pytest.mark.xfail(
PY38, reason="Getting back empty DataFrame", raises=AssertionError,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right is this something we are controlling on pandas side? or pyarrow / fastparquet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea cc @jorisvandenbossche ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh i c this is failing PRs ok let'e merge and can always come back to this (@jbrockmendel if you can make an issue about this)

),
),
[],
],
)
def test_s3_roundtrip_for_dir(
self, df_compat, s3_resource, pa, partition_col, s3so
):
Expand Down