Skip to content

CI: xfail failing parquet test #36272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2020
Merged

CI: xfail failing parquet test #36272

merged 2 commits into from
Sep 11, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@WillAyd WillAyd added the CI Continuous Integration label Sep 10, 2020
@WillAyd WillAyd added this to the 1.1.3 milestone Sep 10, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok by me

@jreback
Copy link
Contributor

jreback commented Sep 11, 2020

is there an issue ref for this?

@jbrockmendel
Copy link
Member Author

is there an issue ref for this?

no

pytest.param(
["A"],
marks=pytest.mark.xfail(
PY38, reason="Getting back empty DataFrame", raises=AssertionError,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right is this something we are controlling on pandas side? or pyarrow / fastparquet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea cc @jorisvandenbossche ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh i c this is failing PRs ok let'e merge and can always come back to this (@jbrockmendel if you can make an issue about this)

@jreback jreback merged commit dc1c849 into pandas-dev:master Sep 11, 2020
@jbrockmendel jbrockmendel deleted the ci-9 branch September 11, 2020 19:25
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 13, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 dc1c849f0cf4f1b8c5602a54f5231f6b57d1d913
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #36272: CI: xfail failing parquet test'
  1. Push to a named branch :
git push YOURFORK 1.1.x:auto-backport-of-pr-36272-on-1.1.x
  1. Create a PR against branch 1.1.x, I would have named this PR:

"Backport PR #36272 on branch 1.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@simonjayhawkins
Copy link
Member

@WillAyd changing the milestone and not backporting. this test is not failing on 1.1.x

@WillAyd
Copy link
Member

WillAyd commented Sep 15, 2020

@jbrockmendel OK by you?

@jbrockmendel
Copy link
Member Author

yep

@TomAugspurger
Copy link
Contributor

Do we have an issue to track this? Could anyone debug if it just the test setup (moto or something?) that was causing us to return empty dataframes, or do we have an actual issue?

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants