-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: xfail failing parquet test #36272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok by me
is there an issue ref for this? |
no |
pytest.param( | ||
["A"], | ||
marks=pytest.mark.xfail( | ||
PY38, reason="Getting back empty DataFrame", raises=AssertionError, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right is this something we are controlling on pandas side? or pyarrow / fastparquet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea cc @jorisvandenbossche ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh i c this is failing PRs ok let'e merge and can always come back to this (@jbrockmendel if you can make an issue about this)
@meeseeksdev backport 1.1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
@WillAyd changing the milestone and not backporting. this test is not failing on 1.1.x |
@jbrockmendel OK by you? |
yep |
Do we have an issue to track this? Could anyone debug if it just the test setup (moto or something?) that was causing us to return empty dataframes, or do we have an actual issue? |
No description provided.