Skip to content

DOC: doc fix #36205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2020
Merged

DOC: doc fix #36205

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
823d3af
DOC: doc fix
simonjayhawkins Sep 7, 2020
50d30d1
double backticks
simonjayhawkins Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.1.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Bug fixes
Other
~~~~~
- :meth:`factorize` now supports ``na_sentinel=None`` to include NaN in the uniques of the values and remove ``dropna`` keyword which was unintentionally exposed to public facing API in 1.1 version from :meth:`factorize` (:issue:`35667`)
- :meth:`DataFrame.plot` and meth:`Series.plot` raise ``UserWarning`` about usage of FixedFormatter and FixedLocator (:issue:`35684` and :issue:`35945`)
- :meth:`DataFrame.plot` and :meth:`Series.plot` raise ``UserWarning`` about usage of FixedFormatter and FixedLocator (:issue:`35684` and :issue:`35945`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should FixedFormatter and FixedLocator have double backticks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too bad the docs build doesn't warn on these things. maybe can have some sort of code check (at least to check the book-ended meth/func and so on

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should FixedFormatter and FixedLocator have double backticks?

not sure. they are mpl classes. added anyway.

may have been better to include the message verbatim in this case instead UserWarning: FixedFormatter should only be used together with FixedLocator as was done for ValueError: buffer source array is read-only above.


.. ---------------------------------------------------------------------------

Expand Down