DOC: doc fix #36205
Merged
DOC: doc fix #36205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dsaxton
reviewed
Sep 7, 2020
doc/source/whatsnew/v1.1.2.rst
Outdated
| @@ -51,7 +51,7 @@ Bug fixes | |||
| Other | |||
| ~~~~~ | |||
| - :meth:`factorize` now supports ``na_sentinel=None`` to include NaN in the uniques of the values and remove ``dropna`` keyword which was unintentionally exposed to public facing API in 1.1 version from :meth:`factorize` (:issue:`35667`) | |||
| - :meth:`DataFrame.plot` and meth:`Series.plot` raise ``UserWarning`` about usage of FixedFormatter and FixedLocator (:issue:`35684` and :issue:`35945`) | |||
| - :meth:`DataFrame.plot` and :meth:`Series.plot` raise ``UserWarning`` about usage of FixedFormatter and FixedLocator (:issue:`35684` and :issue:`35945`) | |||
There was a problem hiding this comment.
Should FixedFormatter and FixedLocator have double backticks?
There was a problem hiding this comment.
too bad the docs build doesn't warn on these things. maybe can have some sort of code check (at least to check the book-ended meth/func and so on
There was a problem hiding this comment.
Should FixedFormatter and FixedLocator have double backticks?
not sure. they are mpl classes. added anyway.
may have been better to include the message verbatim in this case instead UserWarning: FixedFormatter should only be used together with FixedLocator as was done for ValueError: buffer source array is read-only above.
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 8, 2020
simonjayhawkins
added a commit
that referenced
this pull request
Sep 8, 2020
Co-authored-by: Simon Hawkins <[email protected]>
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35831 (comment)