STY: add code check for use of builtin filter function #36089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Sep 3, 2020
| @@ -179,6 +179,10 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then | |||
| invgrep -R --include="*.py" -E "super\(\w*, (self|cls)\)" pandas | |||
| RET=$(($RET + $?)) ; echo $MSG "DONE" | |||
|
|
|||
| MSG='Check for use of builtin filter function' ; echo $MSG | |||
| invgrep -R --include="*.py" -P '(?<!def)[\(\s]filter\(' pandas | |||
There was a problem hiding this comment.
Suggested change
| invgrep -R --include="*.py" -P '(?<!def)[\(\s]filter\(' pandas | |
| invgrep -R --include="*.py" -P '(?<!def )filter\(' pandas |
Is this necessary?
There was a problem hiding this comment.
that would fail on uses of .filter, simplefilter, .apply_filter and more
WillAyd
approved these changes
Sep 3, 2020
|
LGTM |
|
thanks @simonjayhawkins |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #35717 (comment)