Skip to content

CLN: remove extant uses of built-in filter function #35717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

simonjayhawkins
Copy link
Member

No internet for a good part of yesterday so some time to experiment with code cleanups.

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 14, 2020
@jreback jreback merged commit faa6e36 into pandas-dev:master Aug 14, 2020
@jreback
Copy link
Contributor

jreback commented Aug 14, 2020

thanks @simonjayhawkins if all are removed then pls add a code_check to ban these (may not be easy though); its possible have to use a static analyzer

@simonjayhawkins
Copy link
Member Author

would be a good idea

the regex that I used to find these contained false positives (such as simplefilter) will need to look again I just used [^\.]filter\( to get filter calls that weren't methods

will need to put on todo list.

@simonjayhawkins
Copy link
Member Author

I think (?<!def)[\(\s]filter\( could work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants