-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: annotate plotting._matplotlib.tools #35968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simonjayhawkins
merged 25 commits into
pandas-dev:master
from
jbrockmendel:annotate-plotting-tools
Aug 31, 2020
Merged
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4c5eddd
REF: remove unnecesary try/except
jbrockmendel c632c9f
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 9e64be3
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 42649fb
TST: add test for agg on ordered categorical cols (#35630)
mathurk1 47121dd
TST: resample does not yield empty groups (#10603) (#35799)
tkmz-n 1decb3e
revert accidental rebase
jbrockmendel 57c5dd3
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel a358463
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel ffa7ad7
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel e5e98d4
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 408db5a
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel d3493cf
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 75a805a
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 9f61070
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 2d10f6e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 3e20187
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel e27d07f
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel c52bed4
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel b69d4d7
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 1c5f8fd
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 061c9e2
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
jbrockmendel 78dfa6e
TYP: plotting._matplotlib.tools
jbrockmendel 7a8dacb
Merge branch 'master' of https://github.com/pandas-dev/pandas into an…
jbrockmendel 420206e
List->Iterable
jbrockmendel a94acea
Merge branch 'master' of https://github.com/pandas-dev/pandas into an…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return is 1d np.ndarray? axes can also be (np.ndarray, IndexClass)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Index.ravel returns an ndarray, so we always get ndarray here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np.ndarray?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there were a way to indicate
ndarray["Axes"]
I'd agree. until then, it is the "Axes" that is most relevantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so mypy is green since np.ndarray resolves to Any, so Any is compatible with Sequence["Axes"].
I guess that we could add
result = cast(Sequence["Axes"], result)
when numpy types are available.