TYP: annotate plotting._matplotlib.tools #35968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,15 +351,21 @@ def _handle_shared_axes(axarr, nplots, naxes, nrows, ncols, sharex, sharey): | |||
| _remove_labels_from_axis(ax.yaxis) | |||
|
|
|||
|
|
|||
| def _flatten(axes): | |||
| def _flatten(axes: Union["Axes", Sequence["Axes"]]) -> Sequence["Axes"]: | |||
There was a problem hiding this comment.
return is 1d np.ndarray? axes can also be (np.ndarray, IndexClass)?
There was a problem hiding this comment.
Index.ravel returns an ndarray, so we always get ndarray here
There was a problem hiding this comment.
can you update return type
There was a problem hiding this comment.
If there were a way to indicate ndarray["Axes"] I'd agree. until then, it is the "Axes" that is most relevant
There was a problem hiding this comment.
so mypy is green since np.ndarray resolves to Any, so Any is compatible with Sequence["Axes"].
I guess that we could add result = cast(Sequence["Axes"], result) when numpy types are available.
…notate-plotting-tools
…notate-plotting-tools
simonjayhawkins
approved these changes
Aug 30, 2020
|
Thanks @jbrockmendel |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Aug 31, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same idea as #35960, focused on clarifying Axis vs Axes