Skip to content

Merge pull request #1 from pandas-dev/master - #34498 improve the .equals() docstring #35555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

data-RanDan
Copy link

#34498 improve the .equals() docstring

@pep8speaks
Copy link

pep8speaks commented Aug 4, 2020

Hello @data-RanDan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-04 21:19:37 UTC

@WillAyd
Copy link
Member

WillAyd commented Aug 4, 2020

@jorisvandenbossche

@WillAyd WillAyd added the Docs label Aug 4, 2020
@data-RanDan
Copy link
Author

Hi
I'm not sure what causes these failures, i only changed the comments..

@jorisvandenbossche
Copy link
Member

We actually already have an open PR that is trying to address the same issue: #34508

@data-RanDan
Copy link
Author

data-RanDan commented Aug 6, 2020 via email

@WillAyd WillAyd added this to the 1.2 milestone Aug 7, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I think OK to merge

@jorisvandenbossche
Copy link
Member

It's only two weeks, and just a trailing whitespace failure that was remaining in the older PR. So I updated that one.

@jorisvandenbossche
Copy link
Member

@data-RanDan I merged the other PR, so going to close this one. But know that your contribution is very much valued nonetheless! On a big project like pandas it is easy to overlook other issues/PRs. It's always a bit annoying if such duplicate work happens, but given that the other PR was older and further in the review process, decided to merge that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants