-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Merge pull request #1 from pandas-dev/master - #34498 improve the .equals() docstring #35555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @data-RanDan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-04 21:19:37 UTC |
Hi |
We actually already have an open PR that is trying to address the same issue: #34508 |
well' he seems to be at it for a while..
and i just solved it for you
…On Thu, 6 Aug 2020 at 10:31, Joris Van den Bossche ***@***.***> wrote:
We actually already have an open PR that is trying to address the same
issue: #34508 <#34508>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJEEFLI5RBWNQOYIUWCO4TR7JL4BANCNFSM4PUZRASA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I think OK to merge
It's only two weeks, and just a trailing whitespace failure that was remaining in the older PR. So I updated that one. |
@data-RanDan I merged the other PR, so going to close this one. But know that your contribution is very much valued nonetheless! On a big project like pandas it is easy to overlook other issues/PRs. It's always a bit annoying if such duplicate work happens, but given that the other PR was older and further in the review process, decided to merge that one. |
#34498 improve the .equals() docstring