DOC: Docstring updated for DataFrame.equals #34508
Conversation
pandeydeepak0
commented
Jun 1, 2020
•
pandeydeepak0
commented
- closes DOC: improve the .equals() docstring #34498
|
Hello @freakypandit! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-07 18:32:08 UTC |
| be the same dtype. | ||
| the same location are considered equal. The row/column index do not need | ||
| to have the same type (as long as the values are still considered equal). | ||
|
|
There was a problem hiding this comment.
you can leave the blank line here
pandas/core/generic.py
Outdated
| the same location are considered equal. | ||
|
|
||
| The row/column index do not need to have the same type, as long | ||
| as the values are still considered equal. |
There was a problem hiding this comment.
I feel the "still" can be removed. This was used in a different context under "Notes". It makes the sentence slightly confusing when used here. So we will have "as long as the values are considered equal".
There was a problem hiding this comment.
@fujiaxiang added your suggestion, thanks!
|
@freakypandit do you have time to finish this up, else I can pick it up. |
|
@freakypandit can you fix the lint failure. |
|
@simonjayhawkins I will try to do this. |
jorisvandenbossche
changed the title
|
I fixed the trailing whitespace (that was the linting failure) |
|
Thanks @freakypandit ! |
