Skip to content

TYP: remove # type: ignore for unpacking compression_args #35344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

TYP: remove # type: ignore for unpacking compression_args #35344

merged 1 commit into from
Jul 29, 2020

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jul 19, 2020 •
edited
Loading

eg. compresslevel for GzipFile is an int and compression in get_handle is Optional[Union[str, Mapping[str, Any]]] = None

once we adopt TypedDict, then maybe we could be more explicit here, but for now Any is appropriate.

the ignored message for GZipFile is error: Argument 2 to "GzipFile" has incompatible type **Dict[str, str]"; expected "int"

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jul 19, 2020
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 21, 2020
Merged
5 tasks
@WillAyd WillAyd added this to the 1.2 milestone Jul 21, 2020
WillAyd
WillAyd approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; these are just kwargs that get passed to zip file .write correct?

@simonjayhawkins
Copy link
Member Author

lgtm; these are just kwargs that get passed to zip file .write correct?

you mean .open?

@simonjayhawkins
Copy link
Member Author

from https://docs.python.org/3/library/gzip.html?highlight=gzipfile#module-gzip

Changed in version 3.3: Added support for filename being a file object, support for text mode, and the encoding, errors and newline arguments.

so maybe (in a followon) remove the if is_path for compression == "gzip"

@simonjayhawkins simonjayhawkins merged commit a95e680 into pandas-dev:master Jul 29, 2020
@simonjayhawkins simonjayhawkins deleted the compression-args branch July 29, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @WillAyd