Skip to content

Commit a95e680

Browse files
TYP: remove # type: ignore for unpacking compression_args (#35344)
1 parent 55d2c65 commit a95e680

File tree

1 file changed

+11
-18
lines changed

1 file changed

+11
-18
lines changed

pandas/io/common.py

+11-18
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,8 @@ def file_path_to_url(path: str) -> str:
267267

268268

269269
def get_compression_method(
270-
compression: Optional[Union[str, Mapping[str, str]]]
271-
) -> Tuple[Optional[str], Dict[str, str]]:
270+
compression: Optional[Union[str, Mapping[str, Any]]]
271+
) -> Tuple[Optional[str], Dict[str, Any]]:
272272
"""
273273
Simplifies a compression argument to a compression method string and
274274
a mapping containing additional arguments.
@@ -282,21 +282,23 @@ def get_compression_method(
282282
Returns
283283
-------
284284
tuple of ({compression method}, Optional[str]
285-
{compression arguments}, Dict[str, str])
285+
{compression arguments}, Dict[str, Any])
286286
287287
Raises
288288
------
289289
ValueError on mapping missing 'method' key
290290
"""
291+
compression_method: Optional[str]
291292
if isinstance(compression, Mapping):
292293
compression_args = dict(compression)
293294
try:
294-
compression = compression_args.pop("method")
295+
compression_method = compression_args.pop("method")
295296
except KeyError as err:
296297
raise ValueError("If mapping, compression must have key 'method'") from err
297298
else:
298299
compression_args = {}
299-
return compression, compression_args
300+
compression_method = compression
301+
return compression_method, compression_args
300302

301303

302304
def infer_compression(
@@ -434,28 +436,19 @@ def get_handle(
434436

435437
if compression:
436438

437-
# GH33398 the type ignores here seem related to mypy issue #5382;
438-
# it may be possible to remove them once that is resolved.
439-
440439
# GZ Compression
441440
if compression == "gzip":
442441
if is_path:
443-
f = gzip.open(
444-
path_or_buf, mode, **compression_args # type: ignore
445-
)
442+
f = gzip.open(path_or_buf, mode, **compression_args)
446443
else:
447-
f = gzip.GzipFile(
448-
fileobj=path_or_buf, **compression_args # type: ignore
449-
)
444+
f = gzip.GzipFile(fileobj=path_or_buf, **compression_args)
450445

451446
# BZ Compression
452447
elif compression == "bz2":
453448
if is_path:
454-
f = bz2.BZ2File(
455-
path_or_buf, mode, **compression_args # type: ignore
456-
)
449+
f = bz2.BZ2File(path_or_buf, mode, **compression_args)
457450
else:
458-
f = bz2.BZ2File(path_or_buf, **compression_args) # type: ignore
451+
f = bz2.BZ2File(path_or_buf, **compression_args)
459452

460453
# ZIP Compression
461454
elif compression == "zip":

0 commit comments

Comments
 (0)