Skip to content

On traces of #33982 #35030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

On traces of #33982 #35030

wants to merge 1 commit into from

Conversation

kuraga
Copy link

@kuraga kuraga commented Jun 27, 2020

To pay attention on #33982 (comment). Sorry, I don't know another way now.

/cc @mproszewska , @jreback

Thanks.

@WillAyd
Copy link
Member

WillAyd commented Jun 29, 2020

Can you clarify what this is for? I didn't understand from the comment linked

@kuraga
Copy link
Author

kuraga commented Jun 29, 2020

@WillAyd , #33982 introduces index_col argument in _is_potential_multi_index:

- def _is_potential_multi_index(columns):
+ def _is_potential_multi_index(
+     columns, index_col: Optional[Union[bool, Sequence[int]]] = None
+ ):

There are two usages of this function in Pandas:

  1. https://github.com/pandas-dev/pandas/blob/v1.0.5/pandas/io/parsers.py#L1526
  2. https://github.com/pandas-dev/pandas/blob/v1.0.5/pandas/io/parsers.py#L1547

#33982 modifies first call only. In that comment I ask if it is correct.

@alimcmaster1
Copy link
Member

@kuraga - might be worth adding a test to highlight what functionality this changes?

@WillAyd
Copy link
Member

WillAyd commented Sep 10, 2020

Closing as its not clear what this is or solves; if you can clarify further and add a test case can certainly reopen

@WillAyd WillAyd closed this Sep 10, 2020
@kuraga
Copy link
Author

kuraga commented Sep 10, 2020

@WillAyd , it solves nothing. It demonstrates #33982 (comment)

@jreback
Copy link
Contributor

jreback commented Sep 11, 2020

@kuraga ia this actually a bug?

iow can u hit the line of code u added?

@kuraga kuraga deleted the patch-1 branch August 24, 2021 13:36
@kuraga kuraga restored the patch-1 branch August 24, 2021 13:36
@kuraga kuraga deleted the patch-1 branch August 24, 2021 13:36
@kuraga kuraga restored the patch-1 branch August 24, 2021 13:36
@kuraga kuraga deleted the patch-1 branch August 24, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants