Skip to content

BUG: Handling columns from index_col in _is_potential_multi_index #33982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 4, 2020
Merged

BUG: Handling columns from index_col in _is_potential_multi_index #33982

merged 13 commits into from
Jun 4, 2020

Conversation

mproszewska
Copy link
Contributor

@mproszewska mproszewska changed the title BUG: Ignoring columns from index_col in _is_potential_multi_index BUG: Handling columns from index_col in _is_potential_multi_index May 4, 2020
@jreback jreback added IO Excel read_excel, to_excel MultiIndex labels May 5, 2020
jreback
jreback requested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a csv test that hits this

@jreback jreback requested a review from gfyoung May 10, 2020 15:26
@jreback jreback added this to the 1.1 milestone May 10, 2020
@pep8speaks
Copy link

pep8speaks commented May 10, 2020 •
edited
Loading

Hello @mproszewska! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-01 00:42:28 UTC

@mproszewska
Copy link
Contributor Author

I added requested changes.

@mproszewska
Copy link
Contributor Author

Everything should be fine now

@jreback jreback merged commit c71bfc3 into pandas-dev:master Jun 4, 2020
@jreback
Copy link
Contributor

jreback commented Jun 4, 2020

thanks @mproszewska

@kuraga
Copy link

kuraga commented Jun 12, 2020 •
edited
Loading

@mproszewska , thanks very much!

But @mproszewska , @jreback , should we add an argument to this line, too, shouldn't we?

pandas/pandas/io/parsers.py

Line 1601 in c71bfc3

if _is_potential_multi_index(columns):

@kuraga kuraga mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@gfyoung gfyoung Awaiting requested review from gfyoung

Assignees
No one assigned
Labels
IO Excel read_excel, to_excel MultiIndex
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: read_excel: incorrect multi-index values - 1 (empty or equal values)
4 participants
@mproszewska @pep8speaks @jreback @kuraga