Skip to content

TST: rename fixtures named 'indices' to 'index' #35024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

TST: rename fixtures named 'indices' to 'index' #35024

merged 3 commits into from
Jun 26, 2020

Conversation

topper-123
Copy link
Contributor

The singular name makes more sense than the plural.

@jreback jreback added this to the 1.1 milestone Jun 26, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jun 26, 2020
@jreback jreback merged commit b88faa0 into pandas-dev:master Jun 26, 2020
@jreback
Copy link
Contributor

jreback commented Jun 26, 2020

thanks

@topper-123 topper-123 mentioned this pull request Jun 27, 2020
Closed
@topper-123 topper-123 added the Refactor Internal refactoring of code label Jun 27, 2020
@topper-123 topper-123 deleted the rename_tst_indices branch June 27, 2020 00:16
@topper-123 topper-123 linked an issue Jun 27, 2020 that may be closed by this pull request
TST: Rename indices fixture #32974
Closed
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jun 27, 2020
@topper-123 @fangchenli
TST: rename fixtures named 'indices' to 'index' (pandas-dev#35024)
f189cfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

TST: Rename indices fixture
2 participants
@topper-123 @jreback