Skip to content

TST: Rename indices fixture #32974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SaturnFromTitan opened this issue Mar 24, 2020 · 1 comment · Fixed by #35024
Closed

TST: Rename indices fixture #32974

SaturnFromTitan opened this issue Mar 24, 2020 · 1 comment · Fixed by #35024
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Milestone
1.1

Comments

@SaturnFromTitan
Copy link
Contributor

SaturnFromTitan commented Mar 24, 2020 •
edited
Loading

Following up on #28865 (comment) by @simonjayhawkins we should discuss if we want to rename the indices fixture.

A singular name seems more reasonable to its use cases. The most obvious contender is index.

Does any1 have objections?

EDIT: In another comment jreback suggested to use index_fixture instead to make things more obvious. I agree that it would be a better fit
@SaturnFromTitan SaturnFromTitan added the Testing pandas testing functions or related to the test suite label Mar 24, 2020
@SaturnFromTitan SaturnFromTitan mentioned this issue Mar 24, 2020
Merged
3 tasks
@mroeschke mroeschke added the Refactor Internal refactoring of code label May 22, 2020
@topper-123
Copy link
Contributor

Fixed in #35024.

@topper-123 topper-123 added this to the 1.1 milestone Jun 27, 2020
@topper-123 topper-123 linked a pull request Jun 27, 2020 that will close this issue
TST: rename fixtures named 'indices' to 'index' #35024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

TST: rename fixtures named 'indices' to 'index' topper-123/pandas
3 participants
@mroeschke @SaturnFromTitan @topper-123